Add telemetry context propagation across search and load#28
Open
charles-turner-bot wants to merge 4 commits into
Open
Add telemetry context propagation across search and load#28charles-turner-bot wants to merge 4 commits into
charles-turner-bot wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 88.37% 89.70% +1.33%
==========================================
Files 8 9 +1
Lines 456 515 +59
==========================================
+ Hits 403 462 +59
Misses 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a small telemetry-lineage mechanism so catalog usage can be correlated across:
search()to_xarray()materialisationThe implementation is deliberately lightweight:
TelemetryContextdataclass anchored on a stablestore_idIcechunkCatalog.search()and downstream data-source creationcatalog.search,catalog.to_xarray.start, andcatalog.to_xarray.endevents via a callback hookWhy this shape
This avoids relying on Python object identity while still giving us a clean way to trace flows where the same backing icechunk store survives pre/post-search as different Python objects.
I kept it as context propagation + optional emitter hook rather than an accessor-only design, since the main problem seems to be lineage survival across object boundaries.
Testing
pixi run -e test-py313 lintpixi run -e default pytest -qCloses #27.