ESM1.6 style output filenames#6
Open
joshuatorrance wants to merge 25 commits into
Open
Conversation
blimlim
reviewed
May 18, 2026
…set time handling tweaked. Ommitted test case now passes, another now fails
blimlim
reviewed
May 26, 2026
blimlim
reviewed
May 27, 2026
blimlim
reviewed
May 27, 2026
…est to expect failure in this case
blimlim
reviewed
Jun 15, 2026
blimlim
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @joshuatorrance, this is looking good. I've just added a few small questions/comments for discussion.
I've run this on a year's output from ESM1.6, and compared to ACCESS-NRI/um2nc-standalone#241, this gives identical file names!
3 tasks
…er detection of instantaneous files
…. Also added commandline script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESM1.6 is going to be following the OM3 filename patterns.
Todo:
Closes #4