Update to biogenic silica dissolution rates in WOMBATmid#110
Open
pearseb wants to merge 1 commit into
Open
Conversation
…ling base Bsi dissolution rates Removed the 2 exponent on Bsi dissolution due to undersaturation to align with thermodynamics Updated the docs.
pearseb
commented
Apr 30, 2026
|
|
||
| _where_ <br> | ||
| - $T_{K}$ is the in situ temperature of seawater ([`zval`, [ºK]]) <br> | ||
| - $T_{K}$ is the in situ temperature of seawater ([`zval`, [ºK]) <br> |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| - $T_{K}$ is the in situ temperature of seawater ([`zval`, [ºK]) <br> | |
| - $T_{K}$ is the in situ temperature of seawater (`zval`, [ºK]) <br> |
pearseb
commented
Apr 30, 2026
| @@ -1446,7 +1446,7 @@ _where_ <br> | |||
| - $T_{K}$ is the in situ temperature of seawater ([`zval`, [ºK]]) <br> | |||
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| - $T_{K}$ is the in situ temperature of seawater ([`zval`, [ºK]]) <br> | |
| - $T_{K}$ is the in situ temperature of seawater (`zval`, [ºK]) <br> |
pearseb
commented
Apr 30, 2026
| @@ -1446,7 +1446,7 @@ _where_ <br> | |||
| - $T_{K}$ is the in situ temperature of seawater ([`zval`, [ºK]]) <br> | |||
| - $P$ is the in situ pressure [`zm(i,j,k) * 1.0e4`, [Pa]] <br> | |||
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| - $P$ is the in situ pressure [`zm(i,j,k) * 1.0e4`, [Pa]] <br> | |
| - $P$ is the in situ pressure (`zm(i,j,k) * 1.0e4`, [Pa]) <br> |
Collaborator
Author
|
@dougiesquire - no need to attend to this for some weeks. Leave it at the bottom of your to-do list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced
bsi_alphaas a runtime field_table parameter for controlling base Bsi dissolution ratesRemoved the 2 exponent on Bsi dissolution due to undersaturation to align with thermodynamics.
Updated the docs.
These updates come from conversations with Jim Greenwood at CSIRO.