Fix for windows users using this library via 'serverless-dynamodb-local'#47
Open
martineca wants to merge 2 commits into99x:masterfrom
Open
Fix for windows users using this library via 'serverless-dynamodb-local'#47martineca wants to merge 2 commits into99x:masterfrom
martineca wants to merge 2 commits into99x:masterfrom
Conversation
… are affecting windows user when they are trying to start local dynamodb via the serverless-dynamodb-local package. The process starts and immediately shuts down.
Collaborator
|
Thanks @martineca for the PR. I'm also tagging @mjzone to test this in a Mac to see whether it has an effect there as well. Will merge once I get the verification. |
mjzone
approved these changes
May 19, 2019
Author
|
It turns out that this change would cause issues on linux. I will investigate further. |
Collaborator
|
@martineca Let us know if you come across a fix for Linux. @mjzone tested on Mac and it seems to work fine there. |
Author
|
@AshanFernando by using detached:true instead of shell:true the fix should work on all platforms now. |
sutt0n
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding 'shell:true' to the starter.js file. This will fix issues that are affecting windows user when they are trying to start local dynamodb via the serverless-dynamodb-local package. The process starts and immediately shuts down.