Skip to content

馃帹 Palette: Improve accessibility of StationRow component #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

馃帹 Palette: Improve accessibility of StationRow component #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-24 - Accessibility of Interactive Custom Rows
**Learning:** Icon-only delete buttons hidden via opacity (to reduce clutter) are completely inaccessible to keyboard users unless they have a focus state that restores opacity.
**Action:** Always pair `opacity-0 group-hover:opacity-100` with `focus:opacity-100` for interactive elements.
9 changes: 6 additions & 3 deletions components/StationRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ export default function StationRow({
{isCustom && onDelete && (
<button
onClick={onDelete}
className="absolute top-2 right-2 text-red-300 hover:text-red-500 p-1 opacity-0 group-hover:opacity-100 transition-opacity"
aria-label="Remove item"
className="absolute top-2 right-2 text-red-300 hover:text-red-500 p-1 opacity-0 group-hover:opacity-100 focus:opacity-100 transition-opacity"
aria-label={`Remove ${name || 'item'}`}
>
脳
</button>
Expand All @@ -69,6 +69,7 @@ export default function StationRow({
value={name}
onChange={(e) => onNameChange(e.target.value)}
className="text-sm font-medium text-gray-700 dark:text-gray-200 bg-transparent border-b border-transparent hover:border-orange-200 focus:border-orange-500 focus:outline-none w-full mb-1 transition-colors"
aria-label="Item Name"
/>
) : (
<label htmlFor={id} className="text-sm font-medium text-gray-700 dark:text-gray-200">{name}</label>
Expand All @@ -88,12 +89,13 @@ export default function StationRow({
{/* Metadata Area (Arm & Moment) */}
<div className="flex flex-wrap items-center gap-2 text-xs text-gray-400 dark:text-gray-500 mt-1">
<div className="flex items-center gap-1">
<span>Arm:</span>
<span id={`arm-label-${id}`}>Arm:</span>
<input
type="number"
value={arm}
onChange={(e) => onArmChange(e.target.value)}
className={`w-10 bg-transparent border-b border-gray-300 dark:border-gray-600 text-center text-gray-600 dark:text-gray-400 focus:outline-none focus:bg-white dark:focus:bg-gray-800 transition-colors ${isCustom ? 'focus:border-orange-500' : 'focus:border-blue-500'}`}
aria-label={`Arm for ${name}`}
/>
</div>
{/* Moment Display */}
Expand All @@ -118,6 +120,7 @@ export default function StationRow({
${isCustom ? 'focus:ring-orange-500' : 'focus:ring-blue-500'}`}
value={weight || ""}
onChange={(e) => onWeightChange(e.target.value)}
aria-label={isCustom ? `Weight for ${name}` : undefined}
/>
<span className="text-xs text-gray-400 font-medium w-6">
{isFuel && useGallons ? "Gals" : "Lbs"}
Expand Down