fix(awol): drop ambiguous LOA count from summary line#164
Merged
Conversation
Smoke-test feedback: "N total · M LOA" misreads as "M LOAs accounted"
when M is actually the count of flagged troopers currently on an active
LOA — "0 LOA" looked like LOA subtraction hadn't run. Drop the count
entirely; the ⚪ rows and the footer ("AWOL days subtracts valid LOA
days.") already convey LOA involvement. Summary is now "N flagged" on
both healthy and degraded paths; the loud degraded footer still
differentiates degraded mode, so "LOA unknown" in the summary was
redundant. Simplify awolSummaryLine to take only the flagged count.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The prior commit pushed the test changes but not the awol.go change — a stray `git checkout` during local verification reverted awol.go before commit, so the built binary still rendered "N total · M LOA". This re-applies the source change: awolSummaryLine now takes only the flagged count and renders "N flagged"; loaCount aggregation and its threading through runAwol/sendAwolFile/the embed builder are removed. Gate green (re-run as the final step pre-commit). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Smoke-test of the merged #159
/awolsurfaced an ambiguous summary line. The header readN total · M LOA, whereMis the count of flagged troopers currently on an active LOA (the ⚪ rows). In practice56 total · 0 LOAmisreads as "no LOA accounting happened" — when LOA subtraction had in fact run across all users' history.Fix: drop the count. Summary is now just
N flaggedon both the healthy and degraded paths. The ⚪ rows and the footer (AWOL days subtracts valid LOA days.) already convey LOA involvement, and the loud degraded footer (⚠️ … accountable-day adjustment SKIPPED …) still differentiates degraded mode — soLOA unknownin the summary was redundant too.Changes
awolSummaryLinesimplified to take only the flagged count (droppedloaCount+cacheHealthyparams).loaCountaggregation and its threading throughrunAwol/sendAwolFile/embed builder.u.OnLOA()/loaWindowretained — they still drive the ⚪ glyph and[[LOA]]link; only the aggregate count is gone.4107 > 4096, fixed→PASS).Verified live
Smoke build on
developconnected toxenforo-db(5/5 nodes, 1458 windows / 774 users); this is the header copy from that exercise.Gate
lint 0 · tidy clean ·
-racepass · floors OK (utils 90.6%, commands 83.3%) · build OK. Independently re-verified.🤖 Generated with Claude Code