Add full equivalence between different types of linebreaks - #149
Add full equivalence between different types of linebreaks#149tacc-tacc wants to merge 2 commits into
Conversation
…reaks (only when reading)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 2264 2274 +10
=========================================
+ Hits 2264 2274 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Looks good overall. One thing I'd like to see before merging is a test for each behavior-changing part of the diff, such that reverting that change causes at least one test to fail. For example, for line 27 of In general, I'd like the new tests to make the changes in this PR regression-protected. |
|
@5j9 Are you still writing the tests? I can write some of them if you want. |
|
Ah, I think I managed to phrase my previous comment badly enough to make it sound like I was going to write the tests myself. Sorry for the confusion! I meant that I'd like to see the PR updated with tests covering each behavior-changing part of the diff before merging, and I was hoping you would do it. I might eventually add them myself if you don't, but I just don't know when I'll have the free time to do so. |
247ffff to
bc0ebba
Compare
|
@5j9 I added some tests and fixes. Can you accept the PR now? PS: you can't use splitlines in _balanced_quotes_shadow because you lose the linebreaks and we need to keep them untouched, so I changed that for regex.sub. |
Goal: to consider the three linebreaks (\n, \r, and \r\n) all the same while reading/paarsing wikitext.
Changes made: