You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added a new method to the Select class
This method, called id, takes in a parameter of type string and returns an instance of the Select class.
Improved selectItem object configuration
The new method creates a selectItem object, sets its ID property with the provided value, and assigns it as content for the current selectProperty object.
I'd change the name to ::valueById(...) to make it more clear what is done. Just ::id(...) could be confusing, because it breaks apart from the pattern of creating new properties by ::valueSomething(...).
We'd plan to merge this with 1.1.0. Please add tests to your implementation, so we can merge with the dev branch.
just wanted to check with you, if you want to write tests for this feature.
Within our contribution guidlines (https://github.com/5am-code/laravel-notion-api/blob/main/CONTRIBUTING.md) you can double check what is important for a PR to this repo. We want to keep this repo as clean as possible, so we want PRs to stick to those guidelines as best as possible - aside from some exceptions.
If you need any help, please let us know.
We will push v1.1.0 around the end of the week and will cleanup all remaining PRs marked for v1.1.0.
Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shorthand method for when you want to reference a select by its id rather than textual representation.