Skip to content

Incorrect handling of r->main->count #2

Description

@agentzh

When an attack occurs, this module will decrement r->main->count one more time, which can lead to r->main->count overflow. This issue can be trivially reproduced by the mockeagain tool:

https://github.com/agentzh/mockeagain

The following patch fixes this:

diff --git a/ngx_hashdos_module.c b/ngx_hashdos_module.c
index 535b993..0ea8085 100644
--- a/ngx_hashdos_module.c
+++ b/ngx_hashdos_module.c
@@ -235,7 +235,6 @@ ngx_hashdos_request_body_handler(ngx_http_request_t *r)
r->headers_in.content_length_n,count,limit);
ctx->waiting_more_body = 0;
ctx->done = 1;

  •    r->main->count--;
    

    }

    if (ctx->waiting_more_body) {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions