Show the gameplay test run button at the center of the toolbar - #9041
Merged
Conversation
The button now takes the place of the preview button of the other editors, and is the only way to run or stop a test: the duplicated button of the properties panel is removed, so that a test can still be run when the panel is closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
montage-mtipq0eg.mp4
The button used to run a gameplay test was displayed at the right of the toolbar, next to the properties panel icon, while every other editor shows its preview button at the center. It is now displayed in its own centered toolbar group, taking the place of the preview button.
The properties panel had a second "Run the test" button, which is removed: a single button remains, always visible even when the panel is closed. The panel keeps the progress indicator shown while a test is running.
Changes
GameplayTestEditorToolbar: the run/stop button moves to its own centeredToolbarGroup, the properties panel icon stays in the trailing group.MainFrame/Toolbar: the empty placeholderToolbarGroupis not rendered when there is no preview button, so the editor toolbar can provide the centered group itself. This only concerns the gameplay test editor, the only one settingshowPreviewAndShareButtonstofalsewhile showing the project buttons.GameplayTestProperties: the duplicated run/stop buttons are removed, along with the now unusedonRunTestandonStopTestprops (and their plumbing inGameplayTestEditor,GameplayTestEditorContainerand the story).Checklist