Repository navigation
Unify menu and book actions; read native positions directly - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Header Menu clicks could bypass the restrictions applied to the hardware Menu key. Both now share one eligibility rule. Native reading-position reads own their consistency, and book actions own their presentation roles.
The native read no longer needs an application-owned database copy. The book-action module preserves existing labels, order and authorization while removing command-name interpretation from QML.
Evidence
After: Paired header/hardware UI checks pass for each guard and the available state.
After: Native position tests verify read-only WAL access and a writer committing between identity and settings queries: the current read retains its snapshot, and the next read sees the new position.
After: Shared action tests cover local-copy choices, pending upload, conflicts, blocking states, cover-menu placement and signed-out behavior; existing UI and authorization checks pass.
7a8d9fc, including the tap fix. Installed app SHA-256:e31366d6861597141f71fc66b1506d8d76c5834c1b73473d097a580c08cf014f. The installer verified native databases remained unchanged.Merge Danger
Door: two-way
No schema migration or native write changes. Revertible implementation changes.
Blast Radius: interaction
Menu activation, book action rendering, and native position reads during Sync/Open/Upload. The combined build has passed the agreed device check.