Repository navigation
Remove full database backups from position updates - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-commit failures roll back. An uncertain commit remains explicit; the next operation re-reads the firmware database and reconciles either the previous or committed position without restoring stale database contents.
Closes #29.
Evidence
before.dbcopy.After: successful, rolled-back, and uncertain transitions retain only the small text/JSON audit.
ctest --test-dir build/readest-sync/host-linux --output-on-failure— 12/12 passed.docker compose run --rm qt6 make APP=readest-sync check— Qt6 ARM softfp, loader, resource format, and ABI ceilings passed.U743g.6.11.1683: applied the pending Readest position for Beren und Lúthien, opened the native reader, returned, and reopened through Readest Sync. The audit reportedcommitted, contained only four text/JSON files totaling 460 bytes, and created nobefore.db; pending state cleared and local/remote baselines converged.Merge Danger
Door: Two-way
The change is cheap to revert and does not alter the firmware schema or the app's persisted sync format.
Blast Radius: Position apply
Only the explicit Open flow that applies a pending Readest reading position changes. Startup reads, normal native-reader handoff, and PocketBook-to-Readest uploads are unchanged.