feat(workspace): add .firmignore support for ignoring files#54
Open
mrorigo wants to merge 2 commits into
Open
Conversation
mrorigo
commented
Apr 10, 2026
mrorigo
commented
- Add ignore crate dependency for gitignore-style pattern matching
- Refactor load_directory to use WalkBuilder from ignore crate
- Support .firmignore file, with fallback to .gitignore, then no filtering
- Add tests for ignore file logic
- Document feature in workspace.md
- Add ignore crate dependency for gitignore-style pattern matching - Refactor load_directory to use WalkBuilder from ignore crate - Support .firmignore file, with fallback to .gitignore, then no filtering - Add tests for ignore file logic - Document feature in workspace.md
Member
|
Thanks for the PR @mrorigo - would you mind sharing your workflow that needed this feature? |
danielrothmann
requested changes
Apr 17, 2026
Member
danielrothmann
left a comment
danielrothmann
left a comment
There was a problem hiding this comment.
LGTM except I don't think we need special treatment of the schemas folder
| self.load_directory_recursive(directory_path, directory_path) | ||
| } | ||
| // 1. Always load schemas from .firm/schemas/ explicitly - never subject to ignore rules | ||
| let schemas_dir = directory_path.join(".firm").join("schemas"); |
Member
There was a problem hiding this comment.
Although firm init will place built-in schemas in /schemas, schemas in general can be discovered from any subdirectory of the workspace, as well as being inlined into .firm files containing entities.
For this feature, I think it would be more expected that if a schema folder is explicitly ignored, they would not be included in the workspace build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.