Compound query conditions#43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for compound conditions in query
whereclauses, allowing multiple conditions to be combined withandoror.Previously, you could only filter on a single condition per where clause, requiring pipe chaining to combine filters. This made certain queries awkward or impossible - e.g. checking multiple values of an enum field (e.g., "show me invoices that are draft or sent").
The implementation extends the query data model with a
CompoundFilterConditionthat holds multiple conditions and a combinator. The grammar was updated to parse and/or between conditions, with validation that you can't mix them in the same clause (use separate where clauses for that).Syntax:
where <condition> and <condition>where <condition> or <condition>Closes #40