Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the deploy flow to use the new OCI-hosted Helm charts from GHCR instead of the legacy helm repo add/update workflow.
Changes:
- Switch chart references from
elvia-charts/<chart>tooci://ghcr.io/3lvia/charts/<chart>in Helm deploy command construction and tests. - Remove Helm repo add/update command helpers and their unit tests.
- Remove the
--helm-chart-repository-urloverride flag and the corresponding repo setup step inDeploy.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/deploy/helm.go | Uses an OCI chart reference (oci://...) directly in helm upgrade --install, removing repo alias usage. |
| pkg/deploy/helm_test.go | Updates expected command strings to match the new OCI chart reference and removes repo add/update tests. |
| pkg/deploy/deploy.go | Removes the CLI flag and runtime steps that added/updated the Helm repo before deploying. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baksetercx
force-pushed
the
feat/new-helm-oci-charts
branch
from
f131aa8 to
8746891
Compare
baksetercx
force-pushed
the
feat/new-helm-oci-charts
branch
from
8746891 to
b33ee87
Compare
baksetercx
force-pushed
the
feat/new-helm-oci-charts
branch
from
b33ee87 to
1668b2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3lvia/kubernetes-charts#92