refactor: Extract duplicate code into reusable utilities with TDD#3
Merged
Conversation
Phase 1 refactoring eliminates ~200 lines of duplicate code by extracting bridge filtering, data normalization, and event parsing logic into tested utility modules. Adds 32 tests following strict RED-GREEN-REFACTOR cycle. All 122 tests passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bridge-filter.js- Extracts ~100 lines of duplicate bridge filtering logic fromfetch-claims.jsandfetch-last-transfers.jsdata-normalizer.js- Extracts ~80 lines of duplicate amount/BigNumber normalization fromaggregate-claims-transfers.jsandfetch-last-transfers.jsevent-parser.js- Eliminates magic array indices when parsing event args, improving type safetyfetch-last-transfers.test.jsimport validation testCLAUDE.mdwith new utilities and usage examplesTest plan
bridge-filter.js,data-normalizer.js,event-parser.jsfetch-claims.js,fetch-last-transfers.js,aggregate-claims-transfers.jsuse new utilitiespnpm test -- --no-watch --passWithNoTests --watchAll=false🤖 Generated with Claude Code