Repository navigation
Conversation
Found on WSL: `roster vault unlock` said keyctl setperm failed. Its default session keyring is the user-session keyring, whose keys the process doesn't possess, so a key added there can't have its permissions set (0.7.6 moved the add there to fix su, where @U had the same problem). unlock now runs the whole store in a new session keyring (keyctl session -), whose keys are always possessed: added, permissions and timeout set, linked into @U, unlinked; any failure invalidates the key. Checked with the real keyctl on WSL and after su. Version 0.7.10.
CI found both on a fresh container: Arch supports no partial upgrades, so pacman -Sy then -S broke on an openssl transition; both scripts now use pacman -Syu. A GitHub 500 on the bw download failed the whole install; the fzf and bw downloads now retry (3 times, on any error).
vault unlock: store the key from a new session keyring (WSL); 0.7.10
src/errors.rs turns another program's stderr into one line of roster's own, with a hint line when there is a next step. bw's output no longer reaches the terminal: a wrong master password, a missing item, several matches or a locked vault each get a message. A keyring that won't take the session key says why. In run, a Host's stderr is held until its stdout starts or it ends, so ssh's and sudo's failures are told plainly; the command's own stderr still shows, labelled. check gives the same reasons, one line per Host.
A Host setup can't reach, whose password or Box key isn't accepted, or whose host key changed, gets the same message and hint as run. The Mesh and undo scripts' failures show their last line, with the Windows hint on a line of its own. ssh-keygen's output is captured; file errors drop their (os error N). "N Hosts not done" names the command and hints at the rerun.
curl's errors are collected instead of printed, and told by its exit code: a name that won't resolve, nothing listening, a timeout, an untrusted certificate (with the verify: false / -k hint), an empty reply. HTTP 401 and 403, from the request or the token login, read "login refused", with a hint. The password stays masked.
No Inventory names where roster looked and how to name one; a missing -c or ROSTER_CONFIG file says so without an OS error code, with the lookup order as a hint. Bad YAML puts the line up front like every other Inventory error. A usage error's "(see roster -h)" becomes a hint line; an unknown command points at `roster help plugins` too.
fzf or tmux missing or failing in the picker, ssh missing, an unknown Host, an auth: cmd: that fails, no terminal to ask on, and a locked vault during sync's import each get one line and a hint where there's a next step. tmux's stderr is captured; fzf keeps the terminal, as ssh does. File errors in add drop their (os error N).
roster.1 gets a DIAGNOSTICS section listing each message and its hint, and run and web say where their failures are told. The tutorial's troubleshooting table matches the new messages.
Nice errors: one plain line, and a hint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roster 0.7.11
Install on a fresh machine, with every dependency (source only):
Since 0.7.9:
hint:line saying what to do. Raw bw, keyctl, sudo, ssh, curl and fzf output no longer reaches the terminal.wrong master password,no vault item named "X",several vault items match "X", keyring and keyutils problems.sudo rejected the password from bw:ITEM,sudo needs a password, each with the roster.yml fix.ssh-keygen -Rline is shown, never run).login refused (HTTP 401); secrets stay masked.FILE:LINE: not valid YAML.(os error N); usage errors end with a hint.roster vault unlockworks on WSL and aftersu(0.7.10). The session key is stored from a fresh session keyring, sokeyctl setpermno longer fails.make depsand bootstrap: a full upgrade on Arch before installing, and downloads retry.Note:
runnow holds a Host's stderr until its stdout starts or it ends;--jsonstill carries ssh's raw stderr.