Repository navigation
vault unlock: store the key from a new session keyring (WSL); 0.7.10 - #55
Merged
Merged
Conversation
Found on WSL: `roster vault unlock` said keyctl setperm failed. Its default session keyring is the user-session keyring, whose keys the process doesn't possess, so a key added there can't have its permissions set (0.7.6 moved the add there to fix su, where @U had the same problem). unlock now runs the whole store in a new session keyring (keyctl session -), whose keys are always possessed: added, permissions and timeout set, linked into @U, unlinked; any failure invalidates the key. Checked with the real keyctl on WSL and after su. Version 0.7.10.
CI found both on a fresh container: Arch supports no partial upgrades, so pacman -Sy then -S broke on an openssl transition; both scripts now use pacman -Syu. A GitHub 500 on the bw download failed the whole install; the fzf and bw downloads now retry (3 times, on any error).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on WSL:
roster vault unlocksaidkeyctl setperm failed. Its default session keyring is the user-session keyring, whose keys the process does not possess, so a key added there cannot have its permissions set. (0.7.6 moved the add to @s to fixsu, where @U had the same problem.)unlock now runs the whole store in a new session keyring (
keyctl session -), whose keys are always possessed: add, set permissions and timeout, link into @U, unlink. Any failure invalidates the key, and the key stays on stdin. Checked with the real keyctl on WSL (dummy key), and the same method aftersu. Version 0.7.10.