Remove unused percentile from TrustScore

[rlronan]

Fixes #34 .
Percentile is part of the the TrustScore model, but it is never computed. This PR removes it from the base model and docs.

An alternative fix would be to provide the underlying distribution or a lookup table approximation to compute it.

Linting and tests pass

[gemini-code-assist]

Summary of Changes

Hello @rlronan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a technical debt by removing the percentile field from the TrustScore model. This field was part of the model definition but was never computed or utilized in practice. The change simplifies the codebase, improves data model clarity, and ensures that documentation accurately reflects the current state of the system.

Highlights

• Model Simplification: The unused percentile field has been removed from the TrustScore model, streamlining the data structure.
• Documentation Update: All references to the percentile field have been removed from the documentation, ensuring accuracy and consistency.
• Test Fixture Alignment: Test fixtures and helper functions have been updated to reflect the removal of the percentile field, maintaining test integrity.

Changelog

• docs/library.md
  • Removed the percentile entry from the TrustScore fields table.
• docs/mcp-server.md
  • Updated the TrustScore JSON return description to exclude percentile.
• src/good_egg/models.py
  • Removed the percentile field from the TrustScore class definition.
• tests/conftest.py
  • Removed percentile from sample_trust_score fixture initialization.
  • Removed percentile from sample_v2_trust_score fixture initialization.
• tests/test_formatter.py
  • Removed percentile from _make_score helper function.
  • Removed percentile from _make_v2_score helper function.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

🥚 Better Egg: HIGH Trust

Score: 76%

Score Breakdown

Component	Value
Graph Score	76%
Merge Rate	88% (21/24 PRs)
Account Age	2,895 days

Top Contributions

Repository	PRs	Language	Stars
rlronan/ghp-measurement	11	Python	0
suragnair/alpha-zero-general	3	Jupyter Notebook	4381
rlronan/alpha-zero-general	3	Jupyter Notebook	0
2ndSetAI/good-egg	1	Python	17
axolotl-ai-cloud/axolotl	1	Python	11373
rlronan/SLE-GAN	1	Python	0
rlronan/cnn_vis_demo	1	Python	1

[gemini-code-assist]

Code Review

This pull request effectively removes the unused percentile field from the TrustScore model, its associated documentation in docs/library.md and docs/mcp-server.md, and all related test fixtures in tests/conftest.py and tests/test_formatter.py. This is a clean and focused change that improves code maintainability by removing dead code and unnecessary data points. All changes are consistent with the pull request's objective.

[jeffreyksmithjr]

All fine. Just needed a rebase to catch up with main.