Fix WebView Browser Dialer recovery after network handovers - #6229
Open
eliotcougar wants to merge 3 commits into
Open
eliotcougar wants to merge 3 commits into
eliotcougar wants to merge 3 commits into
Conversation
Preserve synchronous start/stop completion and failure propagation for worker-thread network reloads. Supersede queued lifecycle requests and prevent callbacks from reviving destroyed views. Add JVM and real-WebView regression coverage for issue 2dust#6228.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6228.
Network handovers reload the core on a worker thread. With WebView Browser Dialer enabled, stopping the existing WebView from that thread throws and aborts the dialer restart, leaving the connection broken until a manual restart.
Run WebView setup and teardown on the main looper while preserving synchronous completion and error propagation. Invalidate superseded lifecycle requests, clean up failed initialization, and ignore callbacks from destroyed views.
Validation: