i18n: Localize notification-channel names - #6195
eliotcougar wants to merge 1 commit into
Conversation
|
Compatibility note for #6204: the two branches currently have a content conflict in Preferred reconciliation: merge/rebase this channel-localization PR first, then rebase #6204 and have its transient-message channel use |
Replace hard-coded channel labels with dedicated resource names for the main service, subscription updates, and connection checks in all nine supported locales. Resolve names through AppLocaleManager for service and application contexts. Reuse the existing channel when refreshing its localized name, preserving channel IDs and user-controlled importance, sound, vibration, and visibility. Apply initial defaults only to newly created channels and remove the obsolete hard-coded service-channel name. Extract channel localization from local/talkback-all-10 without adding its transient-message channel, snackbar fallback, or accessibility announcement infrastructure.
7b88da8 to
bf7a002
Compare
|
这个完全没有必要，特别是在 NotificationChannelType 还加入了 string 。 |
I'm not sure I understand what you mean. This PR makes notification channel names localized in the Android notification settings. Right now they are always in English. This PR follows the Android guidelines for localized notification channel names. If the user changes the OS language, the notification channel should change without resetting the notification channel preferences (sound, vibration, importance, etc) |
|
Perhaps I explained the scope poorly. These are the channel names users see in Android Settings → Apps → v2rayNG → Notifications, not internal identifiers or notification message text.
Would you prefer keeping the resource mapping in |
2 participants
Replace hard-coded channel labels with dedicated resource names for the main service, subscription updates, and connection checks in all nine supported locales. Resolve names through AppLocaleManager for service and application contexts.
Reuse the existing channel when refreshing its localized name, preserving channel IDs and user-controlled importance, sound, vibration, and visibility. Apply initial defaults only to newly created channels and remove the obsolete hard-coded service-channel name.