Add type hints to source modules (66% function coverage)#285
Open
Kemalau wants to merge 1 commit into
Open
Conversation
Adds parameter and return type annotations to 81 out of 122 functions across all non-test source files in the yamale package: - yamale/command_line.py - yamale/readers/yaml_reader.py - yamale/schema/datapath.py - yamale/schema/schema.py - yamale/schema/validationresults.py - yamale/syntax/parser.py - yamale/util.py - yamale/validators/base.py - yamale/validators/constraints.py - yamale/validators/validators.py - yamale/yamale.py - yamale/yamale_error.py All 156 existing tests pass with no changes to test files. No runtime behavior changes - annotations only. Addresses 23andMe#284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds parameter and return type annotations to 81 out of 122 functions across all non-test source files in the
yamalepackage.Files modified (10):
yamale/command_line.pyyamale/readers/yaml_reader.pyyamale/schema/datapath.pyyamale/schema/schema.pyyamale/schema/validationresults.pyyamale/syntax/parser.pyyamale/util.pyyamale/validators/base.pyyamale/validators/constraints.pyyamale/validators/validators.pyVerification
+138 / -84lines changedApproach
Type annotations were added using an automated tool-assisted workflow with human verification. Each edit was individually tested against the full test suite before proceeding.
Addresses #284