feat: add multi-network support (testnet/signet/regtest) by b-l-u-e · Pull Request #14 · 2140-dev/bitcoin-core-fees

b-l-u-e · 2026-03-07T11:37:37Z

This PR adds multi-network support: the app detects the connected chain via getblockchaininfo RPC and stores fee estimates per network so mainnet and testnet data are not mixed.

Detection: Backend calls getblockchaininfo on startup and when serving fee/blockcount; chain and chain_display are returned to the frontend.
Storage: fee_estimates table has a network column with a migration for existing DBs; collector and read paths filter by current network.
UI: Reusable NetworkBadge shows the detected network (MAINNET / TESTNET / SIGNET / REGTEST) on the dashboard, Stats, and Mempool pages.
Config/docs: rpc_config.ini.example documents port mapping; README updated with multi-network behaviour.

Dependency

i believe this branch depends on #13

Closes #7

ismaelsadeeq · 2026-03-09T22:43:39Z

Thanks for the PR!

Could you rebase this onto the latest master there have been some recent fixes that need to be incorporated.

Also, to make the review easier, it would be great if you could split this into atomic commits, with each commit relating to a single, isolated change

b-l-u-e · 2026-03-10T05:50:29Z

Thanks for the PR!

Could you rebase this onto the latest master there have been some recent fixes that need to be incorporated.

Also, to make the review easier, it would be great if you could split this into atomic commits, with each commit relating to a single, isolated change

Thank you for the feedback I will adjust the changes

ismaelsadeeq

I did a first pass at this.

The organization of the commits seems somewhat arbitrary and does not flow.
You are testing something before it is introduced.

Did you test this locally? I have a branch already with some data, and running this branch seems to cause a recurrent crash in the backend process.

logs

objc[61969]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,161 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,161 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61970]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61970]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,216 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,216 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61971]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61971]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,265 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,265 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61972]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61972]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,353 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,353 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61973]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61973]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,433 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,433 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61974]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61974]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,456 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,457 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61975]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61975]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,521 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,521 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61976]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61976]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,585 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,586 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61977]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61977]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,599 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,599 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61978]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61978]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,655 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,656 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61979]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61979]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
2026-03-12 14:24:40,726 - services.database_service - INFO - Database initialised at /Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin-core-fees/backend/src/services/fee_analysis.db
2026-03-12 14:24:40,726 - collector - INFO - Starting high-resolution fee estimate collector (7s interval)...
objc[61980]: +[NSNumber initialize] may have been in progress in another thread when fork() was called.
objc[61980]: +[NSNumber initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.

Readme.md

backend/tests/test_app.py

b-l-u-e · 2026-03-13T06:50:37Z

Did you test this locally? I have a branch already with some data, and running this branch seems to cause a recurrent crash in the backend process.

yeah it was working on my end... i ran the command again to see if will face the same issue and still running

show logs

2026-03-13 09:44:54,655 - collector - INFO - [Collector] SAVED: target=7 height=295362 rate=1.00 sat/vB
2026-03-13 09:44:54,662 - urllib3.connectionpool - DEBUG - http://localhost:38332 "POST / HTTP/1.1" 200 155
2026-03-13 09:44:54,665 - urllib3.connectionpool - DEBUG - http://localhost:38332 "POST / HTTP/1.1" 200 795
2026-03-13 09:44:54,668 - urllib3.connectionpool - DEBUG - http://localhost:38332 "POST / HTTP/1.1" 200 39
2026-03-13 09:44:54,668 - rpc_service - DEBUG - Network detected: SIGNET (chain=signet)
2026-03-13 09:44:54,670 - urllib3.connectionpool - DEBUG - http://localhost:38332 "POST / HTTP/1.1" 200 39
2026-03-13 09:44:54,673 - urllib3.connectionpool - DEBUG - http://localhost:38332 "POST / HTTP/1.1" 200 519
2026-03-13 09:44:54,677 - services.database_service - DEBUG - Saved estimate: poll_height=295362, target=144, feerate=1.0010000000000001, network=signet
2026-03-13 09:44:54,677 - collector - INFO - [Collector] SAVED: target=144 height=295362 rate=1.00 sat/vB

ismaelsadeeq

yeah it was working on my end... i ran the command again to see if will face the same issue and still running

I debugged this today, and it seems this is not an issue introduced in this PR.
The fork safety crash is a known macOS issue unrelated to these changes export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES suppresses it locally, and I can confirm the branch behaves as expected on my end.

I'd suggest one change in approach — rather than a single fee_analysis.db with a network column, separate the databases by directory to match Bitcoin Core's style data dir convention:

  fee_analysis.db              # mainnet — unchanged, no migration
  testnet3/fee_analysis.db
  signet/fee_analysis.db
  regtest/fee_analysis.db
  e.t.c

The current OR network IS NULL fallback in get_estimates_in_range is fragile and can be prone to bugs.
WHERE network = ? can be dropped from every DB call since isolation is handled at the file level and we just append the test directory, it is easy to reason about.
Existing mainnet data is untouched no migration needed, the root fee_analysis.db path stays the same
With this, it is easy to wipe a network rm -rf testnet3/ without touching another network data

ismaelsadeeq · 2026-03-24T15:11:00Z

A nice extension to this would be to serve estimates for other networks as well, all from the same frontend u.i.

For example, the page could be reloaded to show available networks without needing to restart. The node’s configuration file (rpc_config.ini) could include an added option for the mainnet configuration, and all testnet configurations, excluding regtest.

Then, the UI could display the available networks. I think this aligns well with #14 (review)

b-l-u-e · 2026-03-24T18:06:13Z

the dropdown-style im wandering which option will be better a single active chain per process with one collector targeting the selected RPC or parallel RPC connections with collectors per configured chain with the UI only selecting which chain’s data to fetch.

ismaelsadeeq · 2026-03-25T11:40:57Z

Parallel RPC connections with collectors per configured chain with the UI only selecting which chain’s data to fetch.

This is more ideal

GET /networks returns the list of connected chains. Every existing route (/fees, /blockcount, /mempool-diagram, /performance-data, /fees-sum) now accepts ?chain= to target a specific node. Unknown chain values return 400. DB init runs for every configured chain at startup.

b-l-u-e · 2026-03-28T16:32:28Z

i faced an issue with lint formatting

b-l-u-e requested a review from ismaelsadeeq March 7, 2026 11:38

b-l-u-e force-pushed the feat/multi-network-support branch from ff94a34 to 25c0867 Compare March 10, 2026 19:07

ismaelsadeeq reviewed Mar 12, 2026

View reviewed changes

Readme.md Outdated Show resolved Hide resolved

backend/tests/test_app.py Show resolved Hide resolved

ismaelsadeeq reviewed Mar 23, 2026

View reviewed changes

b-l-u-e added 7 commits March 28, 2026 19:11

backend: multi-node RPC via RpcClient and RpcRegistry

83cd07f

backend: per-chain collectors and per-network database paths

aa701a9

backend: tests for multi-network RPC, registry, and chain routing

f07747e

frontend: chain-aware API client and NetworkContext provider

02f30db

frontend: network switcher dropdown in header, pages use chain context

6876489

docs: update README for parallel multi-network support

2ee6eb2

b-l-u-e force-pushed the feat/multi-network-support branch from 25c0867 to 2ee6eb2 Compare March 28, 2026 16:28

b-l-u-e marked this pull request as draft March 28, 2026 16:32

b-l-u-e marked this pull request as ready for review March 29, 2026 19:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add multi-network support (testnet/signet/regtest)#14

feat: add multi-network support (testnet/signet/regtest)#14
b-l-u-e wants to merge 7 commits into2140-dev:masterfrom
b-l-u-e:feat/multi-network-support

b-l-u-e commented Mar 7, 2026

Uh oh!

ismaelsadeeq commented Mar 9, 2026

Uh oh!

b-l-u-e commented Mar 10, 2026

Uh oh!

ismaelsadeeq left a comment

Uh oh!

Uh oh!

Uh oh!

b-l-u-e commented Mar 13, 2026

Uh oh!

ismaelsadeeq left a comment •

edited

Loading

Uh oh!

ismaelsadeeq commented Mar 24, 2026 •

edited

Loading

Uh oh!

b-l-u-e commented Mar 24, 2026

Uh oh!

ismaelsadeeq commented Mar 25, 2026

Uh oh!

b-l-u-e commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

b-l-u-e commented Mar 7, 2026

Dependency

Uh oh!

ismaelsadeeq commented Mar 9, 2026

Uh oh!

b-l-u-e commented Mar 10, 2026

Uh oh!

ismaelsadeeq left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

b-l-u-e commented Mar 13, 2026

Uh oh!

ismaelsadeeq left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ismaelsadeeq commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

b-l-u-e commented Mar 24, 2026

Uh oh!

ismaelsadeeq commented Mar 25, 2026

Uh oh!

b-l-u-e commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ismaelsadeeq left a comment •

edited

Loading

ismaelsadeeq commented Mar 24, 2026 •

edited

Loading