Repository navigation
Bump Laya: source 0a05a450, model 7b928d82 - #538
Merged
Merged
Conversation
PR Reviewer Guide 🔍(Review updated until commit dd3dcd4)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit d059187 |
|
Persistent review updated to latest commit ad3a5df |
|
Persistent review updated to latest commit dd3dcd4 |
Collaborator
Author
|
Merged after reading the delta, because nothing in the engine consumes
CI green ( |
bong-water-water-bong
added a commit
that referenced
this pull request
Oct 28, 2026
One line: `third_party/laya` `7a77439b0923` -> `b9fe351ce81e`. `config/laya.json` already pins model revision `7b928d828b7b` (unchanged since #317), so this is the source-only half of a bump — the sixth in a row (#439, #452, #459, #511, #538, #568) and the model the router scores is untouched. Nothing in the tree reads or compiles the submodule: `grep -rn third_party/laya` matches only `.github/workflows/bump-laya.yml`, the router builds engine-local `laya/` (`CMakeLists.txt:334`) and the optional fast scorer builds `third_party/ggmlc` (`cmake/laya-ggml.cmake:24`), so the bump-laya workflow's 'run scripts/fetch-laya.sh and the Laya tests' step has no code path to exercise and its HF fetch was deliberately not run while the measurement pass owns this box. Risk: a stale provenance reference only — worst case whoever next diffs the submodule against NandhaKishorM/laya main sees one more commit than the record, revertible by moving the one gitlink back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
third_party/laya:
6f0496f797dc->0a05a45052e2(NandhaKishorM/laya main). config/laya.json revision:7b928d828b7b->7b928d828b7b(convaiinnovations/laya).Before merging: scripts/fetch-laya.sh
(verifies every file) and the Laya tests.