Skip to content

Bump Laya: source 0a05a450, model 7b928d82 - #538

Merged
bong-water-water-bong merged 4 commits into
mainfrom
bump-laya/0a05a450-7b928d82
Oct 25, 2026
Merged

bong-water-water-bong merged 4 commits into
mainfrom
bump-laya/0a05a450-7b928d82

Conversation

@bong-water-water-bong

Copy link
Copy Markdown
Collaborator

third_party/laya: 6f0496f797dc -> 0a05a45052e2 (NandhaKishorM/laya main). config/laya.json revision: 7b928d828b7b -> 7b928d828b7b (convaiinnovations/laya).

Before merging: scripts/fetch-laya.sh

(verifies every file) and the Laya tests.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit dd3dcd4)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@bong-water-water-bong bong-water-water-bong added the hw-gate Run the HRX hardware gate on Strix Halo (docs/hw-gate.md) label Oct 23, 2026
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit d059187

@bong-water-water-bong bong-water-water-bong removed the hw-gate Run the HRX hardware gate on Strix Halo (docs/hw-gate.md) label Oct 23, 2026
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit ad3a5df

@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit dd3dcd4

@bong-water-water-bong
bong-water-water-bong merged commit a675adb into main Oct 25, 2026
8 checks passed
@bong-water-water-bong
bong-water-water-bong deleted the bump-laya/0a05a450-7b928d82 branch October 25, 2026 12:45
@bong-water-water-bong

Copy link
Copy Markdown
Collaborator Author

Merged after reading the delta, because nothing in the engine consumes third_party/laya:

  • grep -rn "third_party/laya" over cmake/, CMakeLists.txt, scripts/, app/, tools/: no hits. The router's
    scorer is built from third_party/ggmlc (cmake/laya-ggml.cmake) and the laya checkpoint comes from
    ~/models/laya-pinned via config/laya.json; the tree builds with third_party/laya empty.
  • So the range 6f0496f7..0a05a450 (96 files, +9058/−233 — releases 0.4.14, the Go/JS ports, the
    llamaindex/langchain/crewai integrations, laya/lang.py) moves a tracked reference (the upstream Python/Go SDK),
    not a build input, and cannot change any artifact.
  • The pin that does matter, the model revision in config/laya.json (7b928d8), is unchanged by this PR:
    scripts/fetch-laya.sh verified all 21 files of convaiinnovations/laya@7b928d828b7b plus the GGUF.
  • Engine side: tests/laya_route_e2e.sh on the candidate build passes — code→hrx (X-1bit-Route: code 0.41 hrx),
    prose→cpu, short→cpu, decision reuse on a second turn, re-decision on a new conversation, clean failure without a
    checkpoint.

CI green (build, CodeQL, pr_agent); hw_gate skipped for a pin-only change.

bong-water-water-bong added a commit that referenced this pull request Oct 28, 2026
One line: `third_party/laya` `7a77439b0923` -> `b9fe351ce81e`. `config/laya.json` already pins model revision `7b928d828b7b` (unchanged since #317), so this is the source-only half of a bump — the sixth in a row (#439, #452, #459, #511, #538, #568) and the model the router scores is untouched. Nothing in the tree reads or compiles the submodule: `grep -rn third_party/laya` matches only `.github/workflows/bump-laya.yml`, the router builds engine-local `laya/` (`CMakeLists.txt:334`) and the optional fast scorer builds `third_party/ggmlc` (`cmake/laya-ggml.cmake:24`), so the bump-laya workflow's 'run scripts/fetch-laya.sh and the Laya tests' step has no code path to exercise and its HF fetch was deliberately not run while the measurement pass owns this box. Risk: a stale provenance reference only — worst case whoever next diffs the submodule against NandhaKishorM/laya main sees one more commit than the record, revertible by moving the one gitlink back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant