Family_id field support - #146
Draft
1aeo wants to merge 1 commit into
Draft
Conversation
This document analyzes the Onionoo codebase to identify which files need modification to support the new family_id field from directory authorities. Key findings: - 7 files require modification in Onionoo core - metrics-lib must be updated first to parse family_id from consensus - Optional: 4 additional files for search/filter support Reference: https://gitlab.torproject.org/tpo/network-health/metrics/onionoo/-/issues/40051 Co-authored-by: 1aeo <1aeo@users.noreply.github.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add detailed implementation analysis for the new
family_idfield.This document outlines all necessary code changes in Onionoo and its dependency
metrics-libto support the upcomingfamily_idfield from directory authorities, including data flow, required modifications, and optional search support.