Open
Conversation
Author
|
Is there anything I can do to help with the required review? |
AndyTitu
reviewed
Jul 14, 2025
volodymyrZotov
added
blocked
By replacing string.Split in ParseVaultAndItemFromPath with a regexp, you can use vault and item names containing slashes
Contributor
|
/ok-to-test sha=09fdc45 |
JillRegan
removed
the
blocked
Contributor
|
✅ E2E tests passed. |
rishiy15
reviewed
Feb 18, 2026
| splitPath := strings.Split(path, "/") | ||
| if len(splitPath) == 4 && splitPath[0] == "vaults" && splitPath[2] == "items" { | ||
| return splitPath[1], splitPath[3], nil | ||
| r := regexp.MustCompile("vaults/(.*)/items/(.*)") |
Contributor
There was a problem hiding this comment.
This is compiling the regex every time a vault and item path is parsed. Can we move this outside the function to the package level?
Comment on lines
+91
to
+94
| "vaults/foo/items/", | ||
| "foo", | ||
| "", | ||
| nil, |
Contributor
There was a problem hiding this comment.
Do we want to allow an empty item string?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By replacing string.Split in ParseVaultAndItemFromPath with a regexp,
you can use vault and item names containing slashes