Repository navigation
[Bugfix] Scope allocator settings during SM70 compile warmup - #840
Merged
Merged
Conversation
Scope compile-time allocation settings and restore the complete configuration before steady-state profiling or returning an explicit KV budget. Extracts the allocator lifetime fix from #690 without changing projection arithmetic. Co-authored-by: OpenAI Codex <noreply@openai.com> Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cold compilation can leave small persistent allocations inside large split segments. Use the existing temporary allocator setting during the first SM70 profile forward, then restore the complete configuration before measuring the steady-state forward or returning an explicit KV budget. This extracts the allocator-lifetime fix from #690; projection arithmetic and cache layouts are unchanged.
Validation:
tools/merge_gate.sh tests/v1/worker/test_sm70_warmup_allocator.py tests/v1/worker/test_gpu_worker_allocator.py tests/v1/worker/test_gpu_worker_memory_profile.pypassed: 95 CPU checks, five hardware-dependent tests skipped. Scoped pre-commit passed. The added cases exercise compile exceptions, explicit KV budgets, ordinary profiling, allocator restoration, existing allocator options and other-platform fallback. Actual peak-memory measurements were not repeated for this revision.The hybrid-page portion of #690 is already integrated through #829. The tiled projection changes remain separate. This is a split of that contribution rather than a duplicate implementation. AI assistance was used.