Repository navigation
[Core][Performance] Avoid singleton hybrid KV cache group sizing - #343
Merged
yangzhuxinyzx merged 1 commit intoAug 27, 2026
Merged
Conversation
Signed-off-by: Leonccaa <166551845+Leonccaa@users.noreply.github.com>
Leonccaa
force-pushed
the
perf/hybrid-kv-singleton-group-size
branch
from
August 27, 2026 14:38
06c4583 to
854a4e0
Compare
Contributor
|
Maintainer audit on latest public main ( |
yangzhuxinyzx
marked this pull request as ready for review
August 27, 2026 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
While validating Qwen3.8 Flash Next with PLE offload, the hybrid cache layer counts were
[1, 12, 12, 12, 36]. The current minimum-count rule selectedgroup_size=1, producing 73 cache groups and repeating slot-mapping and QSA metadata work on every decode step.The singleton is an auxiliary PLE state cache, not the repeating pattern that should define the main hybrid layout.
Solution
When the minimum layer count is exactly one, compute the greatest common divisor of the repeated cache types and choose the largest divisor that keeps aggregate padding at or below 20%. If no safe divisor exists, retain
group_size=1.This is intentionally narrow: configurations without a singleton keep the current behavior.
Validation
6 passed.73 -> 773 -> 724 -> 225.809 -> 34.411 tok/s(+33.33%)Observed during the Flash Next work in #338, but this change is generic and does not depend on that model implementation.
CI note
The remote pre-commit workflow runs with
--all-filesand currently fails on unchanged repository-wide Ruff format, typos, clang-format, markdownlint, SPDX, forbidden-import, andtorch.cudabaselines. Neither file changed by this PR appears in the failure diff. Both changed files pass the full local pre-commit suite, and the remote Python 3.10, 3.11, 3.12, and 3.13 mypy hooks all pass.