Repository navigation
[Bugfix][SM70] Isolate MXFP4 direct-order offsets - #326
Merged
yangzhuxinyzx merged 1 commit intoAug 26, 2026
Merged
Conversation
Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
yangzhuxinyzx
marked this pull request as ready for review
August 26, 2026 06:07
yangzhuxinyzx
deleted the
agent/v100-mxfp4-direct-order-offset-fix-20260826-060007
branch
August 26, 2026 07:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Repair the new quality bug reported on #308 without replaying its stale optimization stack. Current main already contains the accepted direct-order optimization from #314, but B1 graph capture can observe offsets overwritten by M2--M8 warmup or verifier compaction.
Source contract
9bbc554e1d9f63a628d1bc66ecb45ee4632267a2f096a85bf43f3d00df3b25a34299c748ad747b2a052312c66f89bb144cf68f5776d83552c7b9e3d1Fix
slot_expert_offsetsbuffer ([0, 1, ..., 6]).compact_expert_offsets, which M2--M8 compaction mutates before a B1 graph may be captured.The first pre-fix matched endpoint reached
69.949 token/sbut produced incoherent output. It is recorded as rejected quality evidence, not a speed baseline. This repair preserves the already measured optimization while removing the identified cross-shape state leak.Test result
pytest -q tests/quantization/test_sm70_mxfp4_moe.pywith CUDA hidden:25 passed, 4 skipped.pre-commit run --from-ref onecat/main --to-ref HEAD: passed, including Ruff, Markdown, mypy, SPDX, configuration, and forbidden-API checks.Supersedes the post-#314 bugfix portion of #308 after merge.