Repository navigation
[Model][SM70] Exclude unsafe PP2 TP4 QPN8 gate/up - #313
Merged
yangzhuxinyzx merged 3 commits intoAug 26, 2026
Merged
yangzhuxinyzx merged 3 commits into
yangzhuxinyzx merged 3 commits into
Conversation
Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com> (cherry picked from commit a253e04)
Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com> (cherry picked from commit bdc82e8)
Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
yangzhuxinyzx
marked this pull request as ready for review
August 26, 2026 02:56
yangzhuxinyzx
deleted the
codex/v100-dsv4-pp2tp4-qpn8-accuracy-main-20260826-024109
branch
August 26, 2026 02:56
This was referenced Aug 26, 2026
yangzhuxinyzx
added a commit
that referenced
this pull request
Aug 27, 2026
The audited QPN8 functionality is already present through merged PR #313. Preserve the historical commits without replaying the stale policy or tests. Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Rebuild and repair PR #302 on the latest main at 1d64f84.
The original PR changed every admitted PP2 x TP4 QPN8 projection to its lowest-error schedule. Source audit shows that this pays a 15--36% isolated operator slowdown for errors that are already bounded around 1e-5. The actual numerical outlier is only fused shared-expert gate/up.
This repair therefore:
This PR supersedes #302 rather than pushing into the agent-owned branch.
Numerical and performance audit
Four-pattern real-weight comparison against same-process TurboMind:
Matrix artifact:
/data/models/v100-dsv4-0731-pp2tp4-qpn8-accuracy-matrix-20260826-r1/
The conservative all-accuracy source gate passes M=1/M=9, changing-input CUDA Graph replay, FP32/TurboMind references, grouped WO-A layout, both excluded roles, and one reused 16 MiB workspace:
/data/models/v100-dsv4-0731-pp2tp4-qpn8-accuracy-source-gate-20260826-r2-main/
Matched PP2 x TP4 B1 no-spec evidence for that slower all-accuracy variant:
The single GSM8K difference is recorded rather than treated as a greedy-identity failure. It also provides no evidence that selecting the lowest already-small operator error improves aggregate task quality. The accepted source repair is consequently the speed-preserving hybrid: retain every bounded speed winner and fall back only the demonstrated outlier.
Full artifacts:
/data/models/v100-dsv4-0731-pp2tp4-qpn8-accuracy-fullmodel-control-20260826-r1/
/data/models/v100-dsv4-0731-pp2tp4-qpn8-accuracy-fullmodel-candidate-20260826-r2/
Test plan and result