Fix retrieval correctness and input validation - #2
Merged
Conversation
1816x
force-pushed
the
fix/retrieval-correctness
branch
from
August 3, 2026 18:33
173bb00 to
dda7dac
Compare
1816x
force-pushed
the
fix/retrieval-correctness
branch
from
August 3, 2026 18:38
dda7dac to
a55ef54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RAG_MIN_SCORE(default0.09)GET /stats0.15available as an explicit stricter setting; the0.09default separates the bundled demo's relevant HNSW query (0.0930) from its off-topic regression (0.0407)Behavior changes
Hnsw.insert,Hnsw.insert_batch, andHnsw.searchreject NaN and infinity/querymay returnsources: []when no retrieved chunk clears the thresholdDocumentStoreconsumers remain unfiltered unless they setmin_scoreTest plan
GitHub Actions should run:
cargo fmt --all --checkcargo clippy --all-targets -- -D warningscargo testThis PR intentionally excludes UI, upload security, CORS, and Claude timeout work; those remain in PRs 2 and 3.