Repository navigation
Fix exposed key and routing safety - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root causes
The AMap key was hard-coded in application source while generated dependency caches were committed. Routing also used backward traversal over outgoing edges, which is invalid for directed roads, and runtime configuration was tied to one development machine.
Verification
npm ci --ignore-scriptsnpm audit --omit=dev --audit-level=high(0 vulnerabilities)npm run lintnpm run buildMapNavigationTests(all pathfinder regressions passed)Deployment note
The exposed AMap key still exists in Git history and must be revoked or rotated in the AMap console. This PR intentionally avoids rewriting shared Git history.
Local CMake execution was unavailable on the author's machine; the added GitHub Actions job performs the CMake configure, build, and CTest flow on Ubuntu.