Remove unused WAIT_TIMEOUT constant and unused WebDriverWait/EC imports from scrape_whatsapp_chats.py#3
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
Remove WAIT_TIMEOUT (line 22), WebDriverWait import (line 11), expected_conditions import (line 12), NoSuchElementException import, and TimeoutException import. All were orphaned when commit eae4bc4 rewrote get_group_participants() and removed the WebDriverWait usage introduced in commit 0896d81. Also remove the stale WAIT_TIMEOUT entry from README Configuration section since the constant has no effect. Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused WAIT_TIMEOUT constant and orphaned imports
Summary
Removes dead code from
scrape_whatsapp_chats.pythat was left behind when commit eae4bc4 rewroteget_group_participants()and removed theWebDriverWait-based logic originally introduced in commit 0896d81.Removed:
WAIT_TIMEOUT = 10constant (unused, no code references it)from selenium.webdriver.support.ui import WebDriverWait(unused import)from selenium.webdriver.support import expected_conditions as EC(unused import)NoSuchElementExceptionandTimeoutExceptionfrom the exceptions import line (also unused)WAIT_TIMEOUTentry from README Configuration sectionStaleElementReferenceExceptionis retained as it is actively used in the codebase.Review & Testing Checklist for Human
NoSuchElementExceptionis truly unused — the original finding only flaggedWAIT_TIMEOUT/WebDriverWait/EC, but this PR also removesNoSuchElementExceptionandTimeoutExceptionfrom the import. Grep the full file to confirm neither is referenced (e.g., in atry/exceptblock further down).WAIT_TIMEOUT,WebDriverWait, orEC(a quickgrepacross the repo should suffice).README.md— cosmetic only, no functional impact.Notes