chore: replace deprecated datetime.utcnow Column defaults with datetime.now(timezone.utc) in database/models.py#15
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
…me.now(timezone.utc) Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: replace deprecated
datetime.utcnowColumn defaults withdatetime.now(timezone.utc)Summary
Replaces the deprecated
default=datetime.utcnowcallable inFXRate.scraped_atandMidMarketRate.scraped_atColumn definitions withdefault=lambda: datetime.now(timezone.utc).replace(tzinfo=None).datetime.utcnowwas deprecated in Python 3.12 (this repo runs on 3.12.8) and emitsDeprecationWarningon every row INSERT since SQLAlchemy invokes the default callable each time. The replacement uses.replace(tzinfo=None)to continue producing naive UTC datetimes, maintaining compatibility with the existing SQLite schema and any code that reads these columns.Review & Testing Checklist for Human
.replace(tzinfo=None)is the right approach for this codebase — if other parts of the app expect timezone-aware datetimes, this would need to changedatetime.utcnow()call sites exist inmain.pyandscrapers/base.pyand are not addressed here — confirm this scoping is intentionalpython main.py --demoand inspect thescraped_atvalues infx_fees.dbto confirm they are still naive UTC datetimesNotes