-
Notifications
You must be signed in to change notification settings - Fork 6
feat(checkpoint):增加上下文回滚功能 #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
162ef2a
feat(checkpoint):代码与上下文快照定义
phantom5099 e2537b5
Merge remote-tracking branch 'refs/remotes/upstream/main'
phantom5099 29078d0
feat(checkpoint):增加代码回退功能
phantom5099 707fea7
Merge remote-tracking branch 'origin/main'
phantom5099 cd672d6
Merge remote-tracking branch 'upstream/main'
phantom5099 9c2e4b8
feat(checkpoint):修改检查点建立节点
phantom5099 8c70836
test(gateway): 补齐 urlscheme runtime stub
xgopilot c1ab89c
feat(checkpoint):修checkpoint创建节点问题
phantom5099 3d19c70
Merge remote-tracking branch 'origin/main'
phantom5099 ee6464f
test(checkpoint): 补充回滚链路覆盖
xgopilot 846e93c
Merge pull request #68 from phantom5099/fork-pr-547-1777820317
phantom5099 bc50708
test(checkpoint): 补充 checkpoint 覆盖
xgopilot c888c89
Merge pull request #69 from phantom5099/fork-pr-547-1777820317
phantom5099 95573f5
pref(checkpoint):修复untracked文件未被追踪
phantom5099 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sessionStore.DB()is stillniluntil the store has performed its firstensureDB-backed operation, andBuildGatewayServerDepshas not touched the store yet. On a fresh startup this leavescheckpointStoreunset, so checkpoint wiring/repair never runs and the whole feature is silently disabled. Please open the DB explicitly here or fall back to constructing the checkpoint store fromDatabasePath(...).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/code 修复
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修复
internal/app/bootstrap.go冷启动时sessionStore.DB()仍为nil导致 checkpoint store 未初始化的问题。本次修改:
BuildGatewayServerDeps现在会默认按session.DatabasePath(...)构造 checkpoint store,避免冷启动时整条 checkpoint 链路被静默跳过。TestBuildGatewayServerDepsInitializesCheckpointStoreOnFreshStartup,验证 fresh startup 下 runtime 的ListCheckpoints能正常工作。验证:
go test ./internal/app -run 'TestBuildGatewayServerDepsInitializesCheckpointStoreOnFreshStartup|TestBuildRuntimeUsesWorkdirOverride'代码已推送到当前工作分支,并同步创建了 fork 侧 PR:
https://github.com/phantom5099/neo-code/pull/70View job run