Repository navigation
Conversation
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed weights and nonzero gradients can reflect Adam decay or old momentum without a new useful update. This adds a fresh DCP state comparison and an FP32 AdamW counterfactual check, joined with both runs’ raw reward/advantage/gradient evidence. It compares rollout counters and all stored checkpoint state except explicitly excluded launch arguments; cached chunk fingerprints are not reused.
Stacked on #18 (
16def6e0), with no production runtime change. Validation: 155 CPU checks pass, including actual AdamW/DCP controls at LR 1e-3 and 1e-6, six state corruptions and combined CLI checks. Fresh reads also match 17 chunks and counters from the retained earlier tiny Ray/PPO/SGD run; that checkpoint is explicitly rejected for Adam qualification.The result table and scope retain all raw receipts and SHA256 manifests. This does not execute a new official model or fresh Ray worker, prove held-out quality, or measure speed. Older/fused optimizer formats without explicit stored AdamW identity still need actual-worker identity and layout qualification.