Repository navigation
Conversation
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--apply-chat-templateis enabled, the standard dataset has already rendered each prompt to a string. Native rollout applied the template again, causing the official Ouro-Thinking tokenizer to fail before the engine call. Apply the template only to structured message lists; encode rendered strings directly.Incremental draft on #15. The production diff is one condition.
Validation: 631 CPU checks pass, 6 CUDA skips, 3 known factory deselections. Six new prompt-contract cases cover rendered strings, structured messages and plain text, with thinking on/off; the unchanged parent reproduces both rendered-string failures. An official-tokenizer audit checks all 500 MATH-500 prompts in both thinking modes and two completions per prompt: 2,000 exact input-token matches and known-answer rewards.
The official audit uses an explicit Ray transport seam and canonical answer replay, not model generation or quality measurement. Original production and initial fixture failures are retained. See
docs/native_chat_prompt_results.mdandbenchmarks/results/native-chat-prompt/for complete scope, source hashes and raw results.