fix: bump libxsql v1.0.8 -> v1.0.10 + serialize_requests - #16
Merged
Conversation
v1.0.8 lacked the http_query_server::stop() concurrency fix (v1.0.9), so graceful /shutdown could abort on a double-join. Also enable serialize_requests (v1.0.10): the server is non-queue and the libghidra host can deadlock on overlapping decompiler reads (pseudocode/decomp_*), so requests now run one-at-a-time. Tested live: query + graceful shutdown (exit 0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related fixes:
http_query_server::stop()concurrency fix (v1.0.9), so graceful/shutdowncould abort on a double-join.serialize_requests = true: the server is non-queue, and the libghidra host can deadlock on overlapping decompiler reads (pseudocode/decomp_*— documented in the connect skill). Serializing/queryis the safe default.Tested live: query (
format=csv) + graceful/shutdown(exit 0).