feat: ?format= output option + intent-driven output guidance - #11
Merged
Conversation
- Bump libxsql pin v1.0.5 -> v1.0.7 (brings ?format=text|csv|tsv on /query, handled in the shared thinclient; JSON stays the default). - Document format= in the HTTP /help text and README. - Rewrite agent guide 'ALWAYS Show Actual Data' into Selection/Fidelity/ Mechanics: decide display by intent, show real artifacts, consume the JSON envelope rather than piping through a reformatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports two cross-tool improvements from bnsql (all three tools share libxsql).
Feature:
?format=text|csv|tsvon /queryBumps the libxsql pin v1.0.5 → v1.0.7, which adds
format=in the shared thinclienthttp_query_server(ghidrasql delegates to it, so no handler code change here). JSON stays the default; text/csv/tsv are for terminal/pipe use. Documented in/helpand README.Tested live (built against libxsql v1.0.7, analyzing
t_linux.o):?format=text|csv|tsv→ correct body + Content-Type; no param → unchanged JSON envelope.Guidance: rewrite "ALWAYS Show Actual Data"
prompts/ghidrasql_agent.mdrewritten into Selection (decide whether/how much by intent — don't dump tables unprompted), Fidelity (show the real artifact, not a paraphrase), Mechanics (consume the JSON envelope; don't pipe through python/jq to pre-render a table). Mirrors the bnsql guide fix; cross-tool lessons live inbnsql-insights.md.