Repository navigation
Trim redundant comments and tests, add a bundle size check - #2
Merged
Merged
Conversation
Drop comments that restate the code and merge test pairs that covered the same behavior.
- Fail CI when the core bundle grows past 3.25 KB gzipped (3,087 B today) - Correct the README size claim, which said ~2 KB - Stop tracking the .impeccable tool cache - Add npm keywords
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://chore-cleanup-and-ci-microkeys.dhrvs.workers.dev (commit edc2774)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Cleanup (
chore: trim redundant comments and overlapping tests)src/core.ts, the// ----section banners indemos.tsxandcases.ts(the component names and thegroupfield already say it), and two in the bench..d.tsand shows on hover for users) and every comment that explains a non-obvious why.onConflictis called, which it previously passed without checking.Build (
build: add a bundle size check and stop tracking the tool cache)scripts/size.mjsand a Size step incheck.yml. It gzipsdist/index.jsplus the chunks it imports and fails above 3.25 KB. Run locally withpnpm size.site/.impeccable/hook.cache.jsonfrom git and ignores.impeccable/. It held local session IDs and absolute paths.No library behavior changes.
Reviewer notes
formatKeybindingandrecordKeybinding. Users who import onlymicrokeys()may ship less after tree-shaking.LIMITinscripts/size.mjswhen that is intended.Verification
pnpm install --frozen-lockfile,vp check,vp test run(94 tests),vp packandnode scripts/size.mjsall pass locally on this branch, rebased onmain.