Repository navigation
Library fixes, fuller docs and site polish - #1
Merged
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://docs-site-and-parser-fixes-microkeys.dhrvs.workers.dev (commit 07d1dee)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library fixes, docs that match what the library does, and site polish. Each commit stands on its own.
Library
+work."(F\\d+)","([a-z]+)"and"$mod+(Digit[0-9]+)"passed the type check but threw "unknown modifier" at runtime, because the parser split on the regex's own+. A press ending in(…)is now read as one regex. Parse speed is unchanged (the regex is tried only when the press ends with)).ignore.formatKeybindingformats$modfor theappleoption.formatKeybinding("$mod+k", { apple: false })returned "Win+K" on a Mac; it now returns "Ctrl+K".useKeybindingsresubscribes when a ref target mounts or changes after the first render. Before, bindings on a conditionally rendered element never attached.>=18).peerDependenciesMetalisted it with no matchingpeerDependencies, which strict package managers reject.Docs
$modcombos and Escape still fire in inputs), and the options table listsexclusive.site/public/docs.mdmirrors every change. The README uses pnpm for dev setup (npm fails onworkspace:*).Site
not_found_handling: "404-page").Tooling
wrangler.jsoncis formatted (it was failingpnpm checkand thereforeprepublishOnly) and has apreviewsblock, whichwrangler previewbuilds require.check.ymlworkflow runspnpm checkand the site build on pushes to main and on PRs.Verification
pnpm checkpasses with no warnings: 97 unit tests (each new test fails without its fix), typecheck and lint.pnpm site:buildpasses, and the browser test page passes 42/42.wrangler dev.Not in this PR
npm still serves 0.1.0 because the v0.1.1 publish failed with
ENEEDAUTH. The footer still shows v0.1.0.