Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 329a5b6bab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| out+=("$(printf '%q' "$a")") | ||
| done | ||
| # QEMU 0015: do not send unchanged keyboard reports at idle. | ||
| out+=(-global usb-kbd.x-ignore-idle=on) |
There was a problem hiding this comment.
Gate the keyboard property on QEMU support
When using macbox build --upstream or switching qemu/current to a pre-0015 build, this unconditional argument prevents the VM from starting: as the added docs/setup.md warning states, “older builds cannot start with that flag.” The upstream branch of src/container/build-reims.sh explicitly skips the patches, while cmd_up() rewrites --extra-args using qemu_extra() before every stopped-VM start, so removing the argument from vm.toml does not resolve it. This also breaks the documented rollback-by-symlink procedure unless users edit the launcher itself. Check the selected QEMU's capabilities before adding the property so upstream builds and rollback remain usable.
AGENTS.md reference: AGENTS.md:L108-L110
Useful? React with 👍 / 👎.
macOS requests periodic USB keyboard reports even when no key changes. Add QEMU's
usb-kbd.x-ignore-idleproperty and enable it in the generated VM configuration, so an idle keyboard sends reports only when its state changes. Document the flag and the removal required before rolling back to an older QEMU build.A prior measurement found 41.4 idle reports/s with the property off and 0 with it on. Holding
afor 2 seconds produced 19 characters in both cases, andhello world.typed correctly in both. AppleUserHIDDrivers dropped out of the guest's busy list; it previously used 1.2–1.4% of a core.What was tested
git am --committer-date-is-author-date, as used by the build script.bash -n macbox.Not verified