Repository navigation
simulators: idle iOS simulators shut down after 15 minutes; agents stop what they start - #15
Merged
Merged
Conversation
…gents start one only when needed and stop it when done
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mac-sim idle(themac-sim-idle.timeruser unit) now shuts down a pool simulator after 15 minutes idle instead of 20. That'sMAC_SIM_IDLE_MINUTES, in both the script's default and the unit'sEnvironment=.mac-sim down/device_closeas soon as you're done.docs/agents.md,docs/architecture.md, thesimulatorsskill andreferences/ios.md) now say 15 minutes.Why
Simulators left running by agents that finished cost the Mac CPU, RAM and GPU. Twenty minutes left too much of that. The claim, Metro and the tunnel stay, and the next
mac-simcommand boots the simulator again, so the shorter timeout only costs one boot.Tested
bash -n src/sims/bin/mac-sim.mac-sim-idle.timeritself wasn't run with the new value.