Repository navigation
metal2vulkan 0093: dropped command buffers take their standings with them - #10
Merged
Merged
Conversation
…ndings with it With surface_lazy_open_ids (on with Coherent), a command buffer dropped without a commit left the open set, so the standing its encoders left read as committed, and a later encoder could skip a copy in it needed and draw stale pixels. Found by the Codex review of #7.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug the Codex review of #7 found in `surface_lazy_open_ids`.
The bug. A lazy surface keeps a standing: the note that a command buffer's encoder ended with the GPU image holding the surface's truth, so a later encoder can skip copying the bytes in. A standing is only usable once its command buffer committed. With `surface_lazy_open_ids` (on whenever Coherent is), "committed" means "not in the open set". A command buffer dropped without a commit also left the open set, so its standing read as committed, and a later encoder could skip a copy in it needed and draw stale pixels.
The fix (0093). When a command buffer that is still open is dropped, the standings its encoders left are cleared. A committed command buffer already left the open set at its commit, so only a drop without a commit walks the surfaces. The `surface_lazy` report counts these as `dropped-standings`.
Checked
Existing installs pick it up with the update prompt in the README (it rebuilds the GPU stack).