Repository navigation
fix(ui): restore compact toolbar in WebKit without clipping native controls - #32
Conversation
christophersesugh
left a comment
There was a problem hiding this comment.
QA re-review — COMMENT only, not approval.
Scope: PR #32 head 4392eaa806a4b031013c667adaf71fb7630917ed, relative to main 26d4e81756e28a6c28ac9f0c4b3dbc2e86b6f8c9. Inspected the full changed-file patch (CSS, toolbar browser test, browser matrix/config, changelog) and the actual GitHub Actions job logs.
Original issue: WebKit measured a 56px toolbar against the original strict <55px check. The candidate decreases outer toolbar block padding 6px -> 4px each side, retains native control height, retains <55px, adds per-control vertical containment, and permits the independently observed native chapter-select 34–42px range. The intermediate run exposed the formerly Chromium-specific 42px vs 34px assertion; the final revision addresses that assumption without dropping compactness or containment checks. The change is additive to testing and limited in CSS scope; no public API, compiler or trace contract change.
Checks verified on exact fix head: Standard CI #43217293735 PASS: 235 unit (33 files), 82 Chromium UI (14 files), preview/typecheck, package/build, licenses, packed consumers and framework/Markdown hosts. Cross-browser QA #43217293007 PASS: Firefox 82/82, WebKit 82/82. No failure found by these checks in the scoped WebKit fix.
Residual limits: These are headless Linux browser regressions, not a visual sign-off in Safari/macOS/iOS, high text zoom, screen readers, actual audio hardware or physical touch devices. Check those before making broader accessibility/release claims.
Relationship to #31: #31 still has head fa38735a, including the old red WebKit evidence and an additional geometry regression that #32 does not contain. If #32 is merged after maintainer review, rebase/update #31, reconcile duplicated browser-config/workflow changes, rerun the combined 83-test browser suite in Chromium, Firefox and WebKit, and revise the report from FAIL only if those exact CI results justify it. Separately outstanding V-10, docs app, controlled performance, governance/rights and release process gates remain open.
Review outcome: Focused fix is supported by passing automated evidence; no release clearance or merge approval is expressed.
Motivation
Release QA in #31 reproduced a WebKit-only compact toolbar failure: at a 1600×900 viewport the bottom toolbar measured 56px against the existing <55px acceptance assertion. The independent QA geometry test found no overlapping or escaping controls; the height discrepancy should not be treated as proven clipping.
Implementation
Verification
Verified on fix head
4392eaa806a4b031013c667adaf71fb7630917ed:selectis 42px rather than Chromium/Firefox's 34px. The compact-height and added containment checks had already passed. The test now accepts only the measured native-size range while retaining the intended layout invariants.Risk and compatibility
Relationship to #31 and release gates
This is a separate implementation PR because #31 is intentionally verification-only. It only addresses QA-04; QA-01/02/03/05/06/07 (human comprehension, physical-device audio/accessibility, live docs app integration, calibrated performance, design acceptance and publication/source-rights review) remain unverified or maintainer-controlled, not software defects claimed fixed here.
No signing, approval, merge, package publication or release is requested.