Sync AMM post to hardened QuantDEX (SafeERC20 + FoT limitation)#6
Merged
Conversation
Add the fee-on-transfer / standard-ERC20s-only limitation to the 'weaknesses I wrote down' list, and note transfers now use SafeERC20 (USDT-style tokens revert rather than silently fail). Matches the QuantDEX code + SECURITY.md updates. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the fee-on-transfer / standard-ERC20s-only limitation and the SafeERC20 note to the AMM post's 'weaknesses' list, matching the quantgroup code + SECURITY.md changes. Figure unchanged.
🤖 Generated with Claude Code
Summary by cubic
Updates the AMM post to match the hardened QuantDEX contract by adding a “Standard ERC20s only” limitation and noting transfers now use OpenZeppelin
SafeERC20.This clarifies that fee‑on‑transfer/rebasing tokens are unsupported and USDT‑style tokens will revert instead of silently failing.
Written for commit 9569ec6. Summary will update on new commits.