feat(neo4j): implement InsertDocuments for Neo4jVectorIndex#1636
Open
abhicris wants to merge 1 commit into0xPlaygrounds:mainfrom
Open
feat(neo4j): implement InsertDocuments for Neo4jVectorIndex#1636abhicris wants to merge 1 commit into0xPlaygrounds:mainfrom
abhicris wants to merge 1 commit into0xPlaygrounds:mainfrom
Conversation
Adds InsertDocuments trait implementation for the Neo4j vector store, enabling document insertion with embeddings via UNWIND + CREATE Cypher queries. Also fetches the node label from the vector index metadata (labelsOrTypes) so inserted nodes match the index automatically. Partial fix for 0xPlaygrounds#565 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InsertDocumentstrait forNeo4jVectorIndex, enabling document insertion with embeddingsUNWIND $items AS item CREATE (n:Label) SET n = itemCypher pattern for efficient batch insertiondocumentproperty (non-object docs)embedded_textalongside document propertiesnode_labelfield toIndexConfigso the correct label is used for inserted nodesget_indexnow fetcheslabelsOrTypesfromSHOW VECTOR INDEXESand populatesnode_labelautomaticallyPartial fix for #565 (Neo4j provider; other providers can follow the same pattern)
Test plan
cargo check -p rig-neo4jpassestop_nto verify round-trip🤖 Generated with Claude Code