Skip to content

chore: fix variable naming#2330

Merged
igamigo merged 2 commits into
nextfrom
jmunoz-rename-assetId-variables
Jul 17, 2026
Merged

chore: fix variable naming#2330
igamigo merged 2 commits into
nextfrom
jmunoz-rename-assetId-variables

Conversation

@juan518munoz

Copy link
Copy Markdown
Collaborator

Closes #2328

@juan518munoz juan518munoz added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Jul 17, 2026
Comment thread crates/sqlite-store/src/store.sql Outdated
CREATE TABLE latest_account_assets (
account_id BLOB NOT NULL, -- account ID
vault_id BLOB NOT NULL, -- asset's vault id
asset_id BLOB NOT NULL, -- asset's asset id

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
asset_id BLOB NOT NULL, -- asset's asset id
asset_id BLOB NOT NULL, -- asset's id

Perhaps keeping it plain makes more sense

@igamigo
igamigo merged commit 3f39859 into next Jul 17, 2026
21 checks passed
@igamigo
igamigo deleted the jmunoz-rename-assetId-variables branch July 17, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: rename vault_id variables to asset_id

3 participants