feat(debug): record advice mutations from event handlers for replay#2306
feat(debug): record advice mutations from event handlers for replay#2306djolertrk wants to merge 10 commits into
Conversation
|
Is this related to the patch we discussed on the call or is that separate? If it is, the PR should probably target the |
Attach the advice-mutation recorder to the DAP program executor so every on_event invocation of the transaction host is captured during the session, and report the number of recorded mutation sets when the session ends. The recording always describes the final run: the engine clears it whenever the DAP client restarts execution from the beginning.
yes, thanks! heads up, please do not merge until 0xMiden/miden-debug#96 is done and debugger is released. Thanks! |
| // Record the advice mutations produced by the host's event handlers during the session. | ||
| // The recording describes the final (post-restart) run and is what an event-replay | ||
| // debugging session needs to re-execute this transaction without the original host. | ||
| let recorder = executor.record_event_mutations(); |
There was a problem hiding this comment.
How can the recorded advice mutations be extracted and passed on to the debugger? self is consumed and the returned ExecutionOutput does not contain the recorded mutations.
There was a problem hiding this comment.
ah, well I intentionally made this PR not ready, and added the sentence into the changelog file that this is groundwork, but yeah, let me prepare everything here (but I marked it as draft until we merge debugger PR)
let me update it now
|
Hey @djolertrk, are we ready to open this PR now that miden-debug#96 is done? |
yes yes, I am back. :) will do it |
|
@igamigo the new debugger release is based on Edit: or we could create a new point release of debugger, that is based on v0.23 VM cc @bitwalker |
I see. Yeah, we either merge this to |
But even client does not depend on the v0.25 VM, on the next branch, right? We will need to wait for it to be merged here as well... |
|
We have a branch that moves to VM 0.25 which should be merges soon, we can branch from there or wait (should be within today/tomorrow) |
hey @igamigo, please let me know once that PR is merged! Thank you! |
@djolertrk we merged this to |
Thanks @igamigo! I am working on a rebase. |
3 participants
Addresses 0xMiden/miden-debug#93.
Basically follow up on the debuggers part: 0xMiden/miden-debug#96.