feat(NTL): support attachments#2295
Open
igamigo wants to merge 21 commits into
Open
Conversation
…miden-client into igamigo-ntl-attachments
igamigo
marked this pull request as ready for review
July 2, 2026 00:04
…miden-client into igamigo-ntl-attachments
TomasArrachea
self-requested a review
July 3, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also includes some minor refactors.
Closes #2286
RpcError::InvalidResponse. Also left some TODOs for further validations (will open an issue about this)import_notesnow ensures genesis is present up front, avoiding fresh-storeBlockHeaderNotFound(0)failures.sync_notes_with_details()withsync_notes_with_content(..., NoteContentFetch), returning self-containedResolvedSyncNotesBlocks.NoteContentFetchdefines whetherPublicDetailsAndAttachmentsfor state sync andAttachmentsOnlyfor import.SyncedNoteDetailswithSyncedNoteandResolvedNoteContent, making private synced note details unrepresentable.CommittedNote::has_attachments()andblock_num().NoteSyncBlocktoSyncNotesBlock,InputNoteRecord::set_attachmentstoattachments_received. THe latter now skips unchanged writes and reports whether the record changed.SyncedNotecarries its content.check_expected_notestosync_expected_notes.